Propagate make exit code in nrnivmodl.

[1uc]

No description provided.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[azure-pipelines]

✔️ 5821422 -> Azure artifacts URL

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (e94c9e7) to head (5821422).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3199   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         569      569           
  Lines      111206   111206           
=======================================
  Hits        74592    74592           
  Misses      36614    36614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bbpbuildbot]

Logfiles from GitLab pipeline #238269 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[JCGoran]

Huh, I didn't even bother to check the exit code of nrnivmodl (always though it was implied that it was non-zero on error), but yes, this is a good change.
I think modelDB CI should be fine (it doesn't check the exit code, though with this change it'd be useful to do it now), although this may also affect some other repos that don't immediately come to mind.

[1uc]

We call nrnivmodl as part of the regular build process. It must fail (on failure) for cmake --build to fail correctly.