added spm12 standalone installer; and script to extract timings from dicom files #231
Conversation
|
Thanks @chrplr, this is awesome. I'll have closer look asap and merge it into master. |
| @@ -186,3 +186,5 @@ Common problems and fixes | |||
| ========================= | |||
| * libXp.so.6 missing (in ubuntu >= 15.10, for example) | |||
| This is a known is http://askubuntu.com/questions/719839/libxp-so-6-missing-15-10. The idea is to install it manually from official sources https://launchpad.net/ubuntu/wily/+package/libxp6 | |||
|
|
|||
| * Beware: the pathname for "scratch" (directory for cache) must not contain any space character! This triggered a nasty bug in nipype.... | |||
There was a problem hiding this comment.
Ideally, this would go in a separate PR as it has nothing to do with spm12 standalon installation or STC.
There was a problem hiding this comment.
I need to learn how to do better PR ;-)
I only have one branch on my fork of pypreprocess. Should I have created
different branches for different dev?
Chris
Christophe Pallier
Contact info: http://www.pallier.org/w/pmwiki.php/Main/Contact
On Sun, Jun 19, 2016 at 1:15 PM, DOHMATOB Elvis [email protected]
wrote:
In README.rst
#231 (comment):@@ -186,3 +186,5 @@ Common problems and fixes
- libXp.so.6 missing (in ubuntu >= 15.10, for example)
This is a known is http://askubuntu.com/questions/719839/libxp-so-6-missing-15-10. The idea is to install it manually from official sources https://launchpad.net/ubuntu/wily/+package/libxp6
+
+* Beware: the pathname for "scratch" (directory for cache) must not contain any space character! This triggered a nasty bug in nipype....Ideally, this would go in a separate PR as it has nothing to do with spm12
standalon installation or STC.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/neurospin/pypreprocess/pull/231/files/8caa896e8ea92a2478829bd93dbdbe53d287f26a#r67615081,
or mute the thread
https://github.com/notifications/unsubscribe/ABdbMoFkN-AlBR_VpaTi2BpGIwM8hV9Tks5qNSTjgaJpZM4IqgU1
.
There was a problem hiding this comment.
On Sun, Jun 19, 2016 at 2:50 PM, Christophe Pallier <
[email protected]> wrote:
In README.rst
#231 (comment):@@ -186,3 +186,5 @@ Common problems and fixes
- libXp.so.6 missing (in ubuntu >= 15.10, for example)
This is a known is http://askubuntu.com/questions/719839/libxp-so-6-missing-15-10. The idea is to install it manually from official sources https://launchpad.net/ubuntu/wily/+package/libxp6
+
+* Beware: the pathname for "scratch" (directory for cache) must not contain any space character! This triggered a nasty bug in nipype....I need to learn how to do better PR ;-) I only have one branch on my fork
of pypreprocess. Should I have created different branches for different
dev? ChrisYes, you want to create different branches for handling different bugs or
feature requests. This way, you can hop from one branch to another, without
running out of sync. Also, ideally, you never work on the master branch :)
. OK roughly, the basic workflow for doing PRs is:
- you create a new local branch for each new feature you're implementing.
This may be implementing a new feature, or fixing a small group (possibly a
singleton) of tightly linked bugs, etc.
So, you'd run "pull --rebase upstream master && checkout master &&
checkout -b branch-for-feature-xyz". In your local git configuration
(.git/config), "upstream" should point to the official
neurospin/pypreprocess repo, whilst "origin" should point to your forked
version on github (e.g, mine is https://github.com/dohmatob/pypreprocess).- git push -u origin branch-for-feature-xyz, to forward your local changes
to github- on your github pypreprocess repo, github will propose to send a new PR
neurosin/master <== chris/branch-for-cool-stuff. Confirm, and that's it.- do this for any new feature you're implementing, or bug (or small group
of) you're trying to fix.
Hope this helps.… <#m_1057442999557563642_>
-- Christophe Pallier Contact info:
http://www.pallier.org/w/pmwiki.php/Main/Contact
On Sun, Jun 19, 2016 at 1:15 PM, DOHMATOB Elvis _@_.***> wrote: In
README.rst <#231 (comment)
https://github.com/neurospin/pypreprocess/pull/231#discussion_r67615081>:@@ -186,3 +186,5 @@ Common problems and fixes > =========================
- libXp.so.6 missing (in ubuntu >= 15.10, for example) > This is a known
is http://askubuntu.com/questions/719839/libxp-so-6-missing-15-10. The
idea is to install it manually from official sources
https://launchpad.net/ubuntu/wily/+package/libxp6 > + > +* Beware: the
pathname for "scratch" (directory for cache) must not contain any space
character! This triggered a nasty bug in nipype.... Ideally, this would go
in a separate PR as it has nothing to do with spm12 standalon installation
or STC. — You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub <
https://github.com/neurospin/pypreprocess/pull/231/files/8caa896e8ea92a2478829bd93dbdbe53d287f26a#r67615081>,
or mute the thread <
https://github.com/notifications/unsubscribe/ABdbMoFkN-AlBR_VpaTi2BpGIwM8hV9Tks5qNSTjgaJpZM4IqgU1>
.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/neurospin/pypreprocess/pull/231/files/8caa896e8ea92a2478829bd93dbdbe53d287f26a#r67616456,
or mute the thread
https://github.com/notifications/unsubscribe/AAms1NB24AA9F3Xnoh_mviVwwl-sIsIcks5qNTsxgaJpZM4IqgU1
.
Elvis Dohmatob,
sent from my potato...
http://dohmatob.blogspot.fr/, https://team.inria.fr/parietal/elvis/,
https://github.com/dohmatob
|
I've added comments related to the CI failure above. Also, this is fairly critical piece of code, and we'd want a test for it (hence the cod-factorization suggested in my commends above). |
|
For the record I figured out a reasonably straightforward way to install libXp6.so in Ubuntu > 14.04: I find it easier than mucking with /etc/apt/sources.list. |
|
I find it easier than mucking with /etc/apt/sources.list.
But you won't get any updates and updates of other libraries might break
this (though not very likely)
|
Given that libxp6 does have very limited dependencies this is very unlikely. Also something I did not mention is that the recommended mucking around with /etc/apt/ generally involves temporarily adding trusty into your sources e.g. from https://bugs.launchpad.net/ubuntu/+source/libxp/+bug/1517884/comments/10:
So it's pretty much the same anyway ... and adding apt sources from another Ubuntu version does not seem like a great idea. |
|
the recommended mucking around with / etc/apt/ generally involves
temporarily adding trusty into your sources e.g. from
https://bugs.launchpad.net/ubuntu/+source/libxp/+bug/1517884/comments/10:
Ouch
|
No description provided.