Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FWECorrector
was written generally, such that methods beyond bonferoni and montecarlo could be specified if anEstimator
implements one.However, as of yet no such alternate method is implemented, and this generic organization obfuscates the API for the
FWECorrector
, as its not clear what possible options are implmeneted by estimators for monte carlo correction.Here, I make this API more explicit by:
FWECorrector
, instead of any possible yet to defined methodn_iters
to 5000 across the board (except MKDAChi2)montecarlo
arguments directly available toFWECorrector