Update Nilearn API _check_same_fov #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c053fd7.
|
Looks like nilearn also changed how they handle Specifically, when we pass a custom cmap, on an image with only 1 level |
jdkent
reviewed
Feb 2, 2024
Co-authored-by: James Kent <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 88.26% 88.22% -0.05%
==========================================
Files 48 48
Lines 6374 6352 -22
==========================================
- Hits 5626 5604 -22
Misses 748 748 ☔ View full report in Codecov by Sentry. |
jdkent
reviewed
Apr 10, 2024
| with: | ||
| fail_ci_if_error: true | ||
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
will see if this breaks when a pull request is opened from a fork instead of the original repo.
jdkent
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Looks like this works now! thanks @Remi-Gau and @adelavega!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #872