Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute correlation matrix in signal voxels #889

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

JulioAPeraza
Copy link
Collaborator

Closes #888.

As documented in the issue, the correlation matrix for calculating the inflation reduction term in Stouffers, and the same matrix for showing the similarity between IBMA studies in the report, should be calculated in signal voxels.

Changes proposed in this pull request:

  • Here, we calculate that matrix in the Stouffers._preprocess_input method and use the same in the report if it exists.

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.21%. Comparing base (34ad68d) to head (2a6debd).
Report is 2 commits behind head on main.

Files Patch % Lines
nimare/reports/base.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   88.20%   88.21%   +0.01%     
==========================================
  Files          48       48              
  Lines        6339     6353      +14     
==========================================
+ Hits         5591     5604      +13     
- Misses        748      749       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulioAPeraza JulioAPeraza marked this pull request as ready for review July 22, 2024 06:50
Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small spelling error, but otherwise looks good!

nimare/meta/ibma.py Outdated Show resolved Hide resolved
@jdkent
Copy link
Member

jdkent commented Jul 24, 2024

LGTM, thanks @JulioAPeraza!

@jdkent jdkent merged commit 792bed9 into neurostuff:main Jul 24, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The correlation matrix should be calculated in signal voxels
2 participants