Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pymare for rounding issue #897

Merged
merged 1 commit into from
Aug 14, 2024
Merged

bump pymare for rounding issue #897

merged 1 commit into from
Aug 14, 2024

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Aug 14, 2024

Closes # .

Changes proposed in this pull request:

Summary by Sourcery

Bump the pymare dependency version to 0.0.7 to resolve a rounding issue in the project.

Build:

  • Update the pymare dependency version from 0.0.5 to 0.0.7 in setup.cfg to address a rounding issue.

Copy link
Contributor

sourcery-ai bot commented Aug 14, 2024

Reviewer's Guide by Sourcery

This pull request updates the required version of the pymare package from 0.0.5 to 0.0.7 in the setup.cfg file. The change is made to address a rounding issue, as indicated by the PR title.

File-Level Changes

Files Changes
setup.cfg Updated the minimum required version of pymare from 0.0.5 to 0.0.7 in the install_requires section
setup.cfg Updated the pymare version from 0.0.5 to 0.0.7 in the minimum dependencies section

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jdkent - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Thank you for this update. In future pull requests, please fill out the pull request description template. This helps provide context for the changes and makes it easier for reviewers to understand the purpose of the update.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jdkent jdkent added the bug Issues noting problems and PRs fixing those problems. label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (5b6e337) to head (e637733).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files          48       48           
  Lines        6386     6386           
=======================================
  Hits         5635     5635           
  Misses        751      751           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdkent jdkent merged commit f2c42be into main Aug 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant