-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] update workflow and fix example #905
Conversation
Reviewer's Guide by SourceryThis pull request updates the GitHub Actions workflow file and fixes an example script. The changes primarily focus on improving the CI/CD pipeline and correcting a minor issue in an example. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jdkent - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
shell: bash {0} | ||
run: make unittest | ||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v2 | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: unit_${{ matrix.os }}_${{ matrix.python-version }} | ||
path: coverage.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider using a matrix strategy for performance tests
The jobs for performance tests (estimators, correctors, smoke) are very similar. Consider using a matrix strategy to define these jobs, which could reduce duplication and make the workflow easier to maintain.
test_performance:
name: Performance tests
if: ${{ needs.check_skip.outputs.skip == 'false' }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
test-type: [estimators, correctors, smoke]
steps:
- uses: actions/checkout@v2
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: '3.10'
- name: Run ${{ matrix.test-type }} test
run: make performance-${{ matrix.test-type }}
Closes # .
Changes proposed in this pull request:
Summary by Sourcery
Update the CI workflow by standardizing quotation marks and upgrading artifact actions to the latest version. Fix a key access issue in an example script to ensure correct data retrieval.
Bug Fixes:
CI: