Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 and 3.7 #118

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

JulioAPeraza
Copy link
Collaborator

No description provided.

@JulioAPeraza JulioAPeraza added the enhancement New feature or request label Apr 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (604bb4f) to head (3cfb86b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   88.01%   87.79%   -0.23%     
==========================================
  Files          13       13              
  Lines         893      893              
==========================================
- Hits          786      784       -2     
- Misses        107      109       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulioAPeraza JulioAPeraza requested a review from jdkent April 2, 2024 19:35
@JulioAPeraza
Copy link
Collaborator Author

JulioAPeraza commented Apr 2, 2024

@jdkent , I had to open a separate PR to drop support for python 3.6, and 3.7. Please, have a look at it when you get the time.

After merging this one, #117 should be ready for review.

Thank you!

@jdkent
Copy link
Member

jdkent commented Apr 3, 2024

LGTM!

Took a look at our dependents, looks like we aren't too depended on for anything pre python 3.8:

https://github.com/neurostuff/PyMARE/network/dependents?dependent_type=REPOSITORY

@jdkent jdkent merged commit bee163b into neurostuff:master Apr 3, 2024
7 checks passed
@JulioAPeraza JulioAPeraza deleted the drop-py367 branch April 3, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants