Feat: Whitelist tokenfactory hooks #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr0n00gler
requested changes
Jun 18, 2024
jcompagni10
force-pushed
the
feat/whitelist-tf-hooks
branch
from
04fc130
to
e855c8f
Compare
zavgorodnii
reviewed
Jun 19, 2024
sotnikov-s
reviewed
Jun 19, 2024
sotnikov-s
reviewed
Jun 19, 2024
This was referenced Jun 20, 2024
sotnikov-s
reviewed
Jun 20, 2024
zavgorodnii
reviewed
Jun 20, 2024
docs/static/swagger.yaml
Outdated
| type: string | ||
| type: object | ||
| title: >- | ||
| HookWhitelist is the list of hooks which are allowed to be added |
There was a problem hiding this comment.
might be missing something, but why do we have whitelisted_hooks as the key here and HookWhitelist as the value?
There was a problem hiding this comment.
ah need to regen swagger
|
testrun with all PRs: https://github.com/neutron-org/neutron-tests/actions/runs/9606960942 |
sotnikov-s
reviewed
Jun 21, 2024
1. Add missing GetCmdBeforeSendHook query 2. Correctly parse denoms with slashes in subdenom 3. fix typo hiik => hook
|
Testrun with just neutron changes:https://github.com/neutron-org/neutron-tests/actions/runs/9608462857 |
sotnikov-s
approved these changes
Jun 21, 2024
pr0n00gler
approved these changes
Jun 22, 2024
zavgorodnii
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit whitelist of codeID & denomCreator pairs to tokenfactory params. Only allow beforeSend hooks to be called for denoms where the denomCreator and codeID of hook are whitelisted.
This also adds a migration for the tokefactory params that includes hooks that we want to whitelist (NFA and astroport)
related PRs:
neutron-org/neutron-integration-tests#316 --test fixes for this PR to pass
neutron dao changes:
neutron-org/neutron-dao#107
neutron-org/neutron-sdk#150
neutron-org/neutronjsplus#43
neutron-org/neutron-integration-tests#314