Chore: split dex execution from banking operations #NTRN-353 #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it much easier to support simulation queries for all messages
Nice cleanup for monolithic core.go. Also makes future refactors a bit simpler
swelf19
reviewed
Jul 5, 2024
x/dex/keeper/withdraw.go
Outdated
| k.SetPool(ctx, pool) | ||
|
|
||
| if sharesToRemove.IsPositive() { | ||
| if err := k.BurnShares(ctx, callerAddr, sharesToRemove, poolDenom); err != nil { |
There was a problem hiding this comment.
There is still a bank operation. On the other hand there is no such thing like QueryEstimateWithdraw, so may be it's ok. But the top level comment is confusing
jcompagni10
changed the title
swelf19
reviewed
Jul 17, 2024
swelf19
approved these changes
Jul 17, 2024
NicholasDotSol
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK
https://hadronlabs.atlassian.net/browse/NTRN-353
This PR creates an execute method for each dex operation which performs all the core logic except event emission and banking operations.
This makes performing simulations (which do not want banking operations) much simpler.
It is a prerequisite for this PR: https://github.com/neutron-org/neutron/pull/543/files
It also begins a larger process of breaking down all of the core.go methods into more manageable (and readable) functions.
This PR also splits each of the dex messages into its own dedicated file for better readability and easier refactoring in the future.
This PR does not change any logic. It is largely just moving code around with a couple of small changes to event handling so that the ExecuteXX functions do not emit events.
Integration Tests
https://github.com/neutron-org/neutron-tests/actions/runs/9896108148