chore: Remove old dex migrations #625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr0n00gler
previously approved these changes
Jul 15, 2024
joldie777
approved these changes
Jul 18, 2024
quasisamurai
approved these changes
Jul 22, 2024
pr0n00gler
dismissed
their stale review
After a couple of considerations we think it's not safe to remove migrations from the module. Module is a separate entity and if i import it as a third-part developer i must get a guarantee that all changes made by developer in the code also reflected in the state by migrations. What do you think?
pr0n00gler
requested changes
Jul 23, 2024
There was a problem hiding this comment.
After a couple of considerations we think it's not safe to remove migrations from the module. Module is a separate entity and if i import it as a third-part developer i must get a guarantee that all changes made by developer in the code also reflected in the state by migrations. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old dex migrations.
There are multiple incoming PRs (ie. #624) that conflict with these migrations. Since they are no longer necessary we can safely remove them.
Integration Test Run
https://github.com/neutron-org/neutron-tests/actions/runs/9897237914