Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require only mantid framework #21

Merged
merged 1 commit into from
Mar 5, 2024
Merged

require only mantid framework #21

merged 1 commit into from
Mar 5, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Mar 5, 2024

Short description of the changes:

no need to install mantidworkbench, so that it won't intefere with RefRed environment, which only requires the mantid package

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr requested a review from mdoucet March 5, 2024 21:27
@jmborr jmborr self-assigned this Mar 5, 2024
@jmborr jmborr merged commit 5294b9a into master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants