Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cd absorber correction #39

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Add Cd absorber correction #39

merged 3 commits into from
Aug 2, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Jul 31, 2024

Add correction to correct for absorbers.

To test, load the following data in refred (using this version of lr_reduction) and reduce. The two curves should align, with a flat plateau at low Q at about 1:

/SNS/REF_L/IPTS-30101/shared/autoreduce/template_up_cd_small_test.xml

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (next@74dc873). Learn more about missing BASE report.

Files Patch % Lines
...n/lr_reduction/scaling_factors/LRDirectBeamSort.py 47.05% 9 Missing ⚠️
reduction/lr_reduction/event_reduction.py 92.85% 2 Missing ⚠️
reduction/lr_reduction/template.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next      #39   +/-   ##
=======================================
  Coverage        ?   82.23%           
=======================================
  Files           ?       20           
  Lines           ?     2330           
  Branches        ?        0           
=======================================
  Hits            ?     1916           
  Misses          ?      414           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet requested a review from backmari August 2, 2024 16:31
pyproject.toml Outdated Show resolved Hide resolved
@backmari
Copy link
Contributor

backmari commented Aug 2, 2024

I downloaded the PR, installed the lr_reduction package in the RefRed conda environment and started RefRed:

conda activate RefRed
cd LiquidsReflectometer/
gh pr checkout 39
pip install .
cd ../RefRed/
python scripts/start_refred.py 

After loading the xml-file in the PR description and reducing in RefRed, the curves align as expected:

Screenshot from 2024-08-02 09-43-40

@mdoucet mdoucet merged commit 365f9b5 into next Aug 2, 2024
1 check passed
@mdoucet mdoucet deleted the cd_absorber branch August 2, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants