Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document creating releases but differentiate between major/minor/patch releases #40

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Aug 2, 2024

Description of work:

Check all that apply:

  • added release notes (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • release notes updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@jmborr jmborr self-assigned this Aug 2, 2024
Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (next@365f9b5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #40   +/-   ##
=======================================
  Coverage        ?   82.23%           
=======================================
  Files           ?       20           
  Lines           ?     2330           
  Branches        ?        0           
=======================================
  Hits            ?     1916           
  Misses          ?      414           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit 0581118 into next Aug 2, 2024
1 check passed
@jmborr jmborr deleted the document_creating_releases branch August 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants