Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyoncat conda #108

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Pyoncat conda #108

merged 3 commits into from
Sep 27, 2023

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Sep 27, 2023 •
edited
Loading

  • pyoncat added as a conda package
  • some extra comments removed in conf.py

*Note:
Add the channel for pyoncat before installation:
conda config --add channels oncat

peterfpeterson
peterfpeterson requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyoncat needs to be added to the meta.yaml and we should (somehow) remember the extra channel in the deploy repo.

peterfpeterson
peterfpeterson approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of a test in the conda packaging

@mpatrou mpatrou merged commit 666407a into next Sep 27, 2023
3 checks passed
@mpatrou mpatrou deleted the pyoncat_conda branch September 27, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfpeterson peterfpeterson peterfpeterson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpatrou @peterfpeterson