Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample log - MDScale #130

Merged
merged 6 commits into from
May 17, 2024
Merged

Sample log - MDScale #130

merged 6 commits into from
May 17, 2024

Conversation

ktactac-ornl
Copy link
Contributor

Short description of the changes:

Updates the sample log when a scale factor is applied

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@mpatrou mpatrou self-requested a review May 9, 2024 20:21
@ktactac-ornl ktactac-ornl requested a review from mpatrou May 17, 2024 15:02
Copy link
Collaborator

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@AndreiSavici AndreiSavici merged commit e9b787f into next May 17, 2024
4 checks passed
@AndreiSavici AndreiSavici deleted the sampleLogUpdate-scaleFactor branch May 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants