Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEConfig update for Sample Parameters and Polarization Options #132

Merged
merged 6 commits into from
May 20, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented May 17, 2024

Short description of the changes:

The code contains changes related to MDEConfig SampleLog. The MDEConfig is updated for Sample Parameters and Polarization Options every time the values are updated (Sample Parameters Dialog, Polarization Dialog and Refine UB tab), if there is an existing MDEConfig in the workspace.

Related tests added/updated.

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.29730% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.61%. Comparing base (a9297e4) to head (2dbfa01).
Report is 4 commits behind head on next.

Files Patch % Lines
src/shiver/models/sample.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #132      +/-   ##
==========================================
+ Coverage   82.30%   82.61%   +0.30%     
==========================================
  Files          39       39              
  Lines        6048     6199     +151     
==========================================
+ Hits         4978     5121     +143     
- Misses       1070     1078       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreiSavici AndreiSavici merged commit e3b3e56 into next May 20, 2024
4 checks passed
@AndreiSavici AndreiSavici deleted the mde_config_sample branch May 20, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants