Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue that parameters are resolved as strings #133

Merged
merged 3 commits into from
May 20, 2024

Conversation

AndreiSavici
Copy link
Member

Short description of the changes:

Minor issue that parameters are resolved as strings

Long description of the changes:

getPropertyValue for False will return "0", which evaluates to True. Using getProperty("PropertyName").value returns a bool.
Similarly, the mask_btp_inputs is a string "[]" which evaluates to True

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@mpatrou mpatrou requested a review from ktactac-ornl May 20, 2024 18:07
@AndreiSavici AndreiSavici merged commit 89e5acc into next May 20, 2024
4 checks passed
@AndreiSavici AndreiSavici deleted the parameter_fixes branch May 20, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants