Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in handling pause, and MD workspaces with no UB #142

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

AndreiSavici
Copy link
Member

Short description of the changes:

Pause was not handled correctly. In the test it would have killed all events, and it would crash on ConvertToMD.
The sample dialog would crash if no UB is already present in the workspace

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@AndreiSavici AndreiSavici enabled auto-merge (squash) October 10, 2024 12:13
@AndreiSavici AndreiSavici requested a review from mpatrou October 10, 2024 12:13
Copy link
Collaborator

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!!

@AndreiSavici AndreiSavici merged commit 0831391 into next Oct 10, 2024
4 checks passed
@AndreiSavici AndreiSavici deleted the pause_and_ub_fixes branch October 10, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants