Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping runs based on s2 #153

Merged
merged 6 commits into from
Feb 27, 2025
Merged

Grouping runs based on s2 #153

merged 6 commits into from
Feb 27, 2025

Conversation

KyleQianliMa
Copy link
Contributor

@KyleQianliMa KyleQianliMa commented Feb 26, 2025

Short description of the changes:

This or fixes the defect of not grouping files based on s2 angle. This only applies to HYSPEC when the detector moves during experiment.

Additional tests were also added to capture this behaviour.

EWM 9809

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (81ba23b) to head (21b0c0c).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #153      +/-   ##
==========================================
+ Coverage   82.33%   82.58%   +0.25%     
==========================================
  Files          39       39              
  Lines        6209     6214       +5     
==========================================
+ Hits         5112     5132      +20     
+ Misses       1097     1082      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KyleQianliMa KyleQianliMa marked this pull request as ready for review February 26, 2025 22:11
Copy link
Member

@AndreiSavici AndreiSavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@AndreiSavici AndreiSavici merged commit cf61641 into next Feb 27, 2025
6 checks passed
@AndreiSavici AndreiSavici deleted the grouping_s2 branch February 27, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants