Skip to content

Commit

Permalink
Merge pull request #24 from nevissecurity/feature/NEVISACCESSAPP-5344…
Browse files Browse the repository at this point in the history
…_Use_custom_FacetId

NEVISACCESSAPP-5344: Use custom FacetId
  • Loading branch information
tamas-toth authored Nov 14, 2023
2 parents a392db1 + e4e2cc6 commit 8ab16f7
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 25 deletions.
11 changes: 0 additions & 11 deletions .github/actions/update-config/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ inputs:
host-name:
description: 'The host name to update'
required: true
android-facet-id:
description: 'The android facet id to update'
required: false

runs:
using: composite
Expand All @@ -25,11 +22,3 @@ runs:
file: assets/config_authentication_cloud.json
field: sdk.hostname
value: "${{ inputs.host-name }}.mauth.nevis.cloud"

- name: Update Configuration (facetId)
if: ${{ inputs.android-facet-id }}
uses: jossef/[email protected]
with:
file: assets/config_authentication_cloud.json
field: sdk.facetId
value: "${{ inputs.android-facet-id }}"
1 change: 0 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ jobs:
build-number: ${{ needs.versioning.outputs.build }}
secrets:
HOST_NAME: ${{ secrets.HOST_NAME }}
ANDROID_FACET_ID: ${{ secrets.ANDROID_FACET_ID }}
KEYSTORE_FILE: ${{ secrets.KEYSTORE_FILE }}
SIGNING_CONFIGS: ${{ secrets.SIGNING_CONFIGS }}
GITHUB_USERNAME: ${{ secrets.GH_USERNAME }}
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/publish_android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ on:
secrets:
HOST_NAME:
required: true
ANDROID_FACET_ID:
required: true
KEYSTORE_FILE:
required: true
SIGNING_CONFIGS:
Expand Down Expand Up @@ -54,7 +52,6 @@ jobs:
uses: './.github/actions/update-config'
with:
host-name: ${{ secrets.HOST_NAME }}
android-facet-id: ${{ secrets.ANDROID_FACET_ID }}

# Make sure the stable version of Flutter is available
- name: Setup Flutter
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ Before being able to use the example app with your Authentication Cloud instance
Edit the `assets/config_authentication_cloud.json` file and replace
- the host name information with your Authentication Cloud instance
- the FacetId with your Android FacetId
```json
{
Expand All @@ -80,7 +79,6 @@ Edit the `assets/config_authentication_cloud.json` file and replace
},
"sdk": {
"hostname": "<YOUR INSTANCE>.mauth.nevis.cloud",
"facetId": "<YOUR ANDROID FACET_ID>",
...
}
}
Expand Down
1 change: 1 addition & 0 deletions assets/config_authentication_cloud.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
},
"sdk": {
"hostname": "myinstance.mauth.nevis.cloud",
"facetId": "android:apk-key-hash:ch.nevis.mobile.authentication.sdk.flutter.example",
"networkTimeoutInSeconds": "60",
"authenticationMaxRetries": 3,
"authenticationRetryIntervalInSeconds": "1",
Expand Down
1 change: 1 addition & 0 deletions assets/config_identity_suite.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
},
"sdk": {
"baseUrl": "https://mycompany.com",
"facetId": "android:apk-key-hash:ch.nevis.mobile.authentication.sdk.flutter.example",
"registrationRequestPath": "/nevisfido/uaf/1.1/request/registration/",
"registrationResponsePath": "/nevisfido/uaf/1.1/registration/",
"authenticationRequestPath": "/auth/fidouaf",
Expand Down
16 changes: 8 additions & 8 deletions lib/getit_root.config.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8ab16f7

Please sign in to comment.