Add/secondary module inputs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it may be helpful to test a module at main rather than at the currently tagged version will rely on smart inputs to avoid failures
wpscholar
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
@circlecube This PR looks good, but needs to be synced with the main branch.
wpscholar
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature to also update a secondary module before running tests.
New inputs:
secondary-module-repo&secondary-module-branchEngineers must take care to pass in an existing branch. If the module-repo or module-branch do not exist, (or if the current branch is sent) the checkout command will fail.
An idea for future improvement would be to also allow a tag/version of the secondary module, so we can easily test a released module that has not yet arrived in the plugin. For now, we'll have to rely on the plugin-branch input (it defaults to
mainbut any could be used). In this scenario, the engineer would need to first create a branch on the plugin, update the secondary module in question on that branch, and then pass it in as the plugin-branch value.See the test PR on coming-soon module which shows that this functionality works as expected: newfold-labs/wp-module-coming-soon#29