Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing trailing slash in rsync command #8

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

The rsync command was missing the trailing slash so it wasn't properly copying build files into the npm dir. This should fix that and the module test workflow will reflect branch changes in js too now.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube merged commit 0d89030 into main Apr 17, 2024
1 check passed
@circlecube circlecube deleted the fix/module-build-rsync branch April 17, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants