Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unistall Woo and its exts after running tests #42

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Nov 24, 2024

Proposed changes

Even though we were deactivating Woo after the tests, since it was leaving left over extensions, Onboarding was seeing the site as ecomm on all tests, hence the failing tests.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani merged commit e922c0a into main Nov 24, 2024
5 of 6 checks passed
@wpalani wpalani deleted the fix/onboarding-tests branch November 24, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant