Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS0-1996: Add Hiive events via HTML attributes #101

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bradp
Copy link

@bradp bradp commented Sep 16, 2024

Proposed changes

This change allows for adding HTML attributes to an element and will send an event to Hiive when the element is clicked.

The attributes you can add are:

  • data-nfd-click Required. Will be used as the key if no other attributes are used.
  • data-nfd-event-key Optional. Used as key if present.
  • data-nfd-event-category Optional. Used as category if present.
  • data-nfd-brand Optional. Used to override brand if present.
  • data-nfd-queue Optional. Will set the event to be queued.
  • data-nfd-product-id Optional. Used for marketplace items.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant