Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page_view to disabled events #104

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Add page_view to disabled events #104

merged 1 commit into from
Oct 18, 2024

Conversation

BrianHenryIE
Copy link
Contributor

Proposed changes

PR #103 included pageview but in retrospect, I think the correct one was page_view.

This suggests there is a longstanding error on this line:

if ( 'pageview' === $event->key ) {

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@BrianHenryIE BrianHenryIE merged commit 961fe52 into main Oct 18, 2024
7 of 9 checks passed
@BrianHenryIE BrianHenryIE deleted the fix-queue branch October 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants