check if wp_is_serving_rest_request exists first

[circlecube]

move the logic into its own method to keep it readable

Proposed changes

Still hitting a fatal error in tests where the method is undefined. This checks if it exists before attempting to use it. Since it's only used to determine the timeout, this isn't too big a deal if the method isn't defined.

I suspect it's only being called because we're spoofing a token in our test since the solutions request bails if there's no connection. But not sure why the method would be undefined in that case, this should take care of the fatal though.

Type of Change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Video

Checklist

• I have read the CONTRIBUTING doc
• I have viewed my change in a web-browser
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[circlecube]

Reworked the tests so this fatal isn't showing up anymore, but this is still worth a review I think.

[BrianHenryIE]

wp_is_serving_rest_request() is defined in functions.php so it will always be available when WordPress is loaded.

I presume then the unit tests are failing, but where?! The correct way to mock the function is with:

wp-module-data/tests/phpunit/includes/HiiveConnectionTest.php

Lines 144 to 146 in ddfeb6e

	WP_Mock::userFunction( 'wp_is_serving_rest_request' )
	->once()
	->andReturnFalse();

I would prefer not to merge this change, since it's not really a production issue, so the fix shouldn't be in production code.

And unimportant to this usage, but I believe wp_is_serving_rest_request() would return false during our bootstrap.php because REST_REQUEST is not defined until later – in rest_api_loaded() – hooked in wp-includes/default-filters.php – called during parse_request() function which I think is hooked on wp.

[circlecube]

I was referring to the cypress tests. There was a fatal error Fatal error: Uncaught Error: Call to undefined function NewfoldLabs\WP\Module\Data\wp_is... not sure how it would be undefined though. The cypress test was running a CLI command to set a token. I've since changed the module and then the test since we didn't need to require a token just a capability.

I'm fine with closing as we have never had this issue before, this PR was troubleshooting mainly.