Press4 498 #60
Merged
Press4 498 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see in the ticket acceptance criteria that we should "set the value for existing sites on an upgrade routine." I don't see anything here that is doing that piece, is it still needed? |
* main: commit workflow contents add brand plugin test workflow more lint fixes some lint fixes `use function WP_Forge\Helpers\dataGet;` Fix #61 Require `wp-forge/helpers` fixing linting issues passing only the array keys instead of entire values Fixed the deprecated warning from wp-module-data module delete useless autogen comment Linting/spacing Add `server_path` to `get_core_data()` using `ABSPATH` Add WP_Mock for tests
|
@manikantakailasa - Did you see the post that @circlecube left here several days ago? I'm accepting this PR as I think that we can roll these changes, and I assume you'll follow up with a PR for the upgrade routine? |
wpscholar
approved these changes
Mar 18, 2024
We are working on upgrade routine will raise new pr related to the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRESS4-498