code clean up and corrected 'contain' assertion

newfold-labs · Jul 4, 2024 · d25d8f2 · d25d8f2
1 parent 12264e3
commit d25d8f2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/tests/cypress/integration/Home/ecommerce-coming-soon.cy.js b/tests/cypress/integration/Home/ecommerce-coming-soon.cy.js
@@ -14,7 +14,6 @@ describe(
 	() => {
 		beforeEach( () => {
 			wpLogin();
-			// uninstallPlugins();
 			comingSoon( true );
 			cy.visit( '/wp-admin/admin.php?page=' + pluginId + '#/home' );
 		} );

diff --git a/tests/cypress/integration/Home/ecommerce-live.cy.js b/tests/cypress/integration/Home/ecommerce-live.cy.js
@@ -2,7 +2,6 @@ import { GetPluginId } from '../wp-module-support/pluginID.cy';
 import {
 	wpLogin,
 	comingSoon,
-	uninstallPlugins,
 } from '../wp-module-support/utils.cy';
 
 const customCommandTimeout = 20000;
@@ -11,7 +10,6 @@ const pluginId = GetPluginId();
 describe( 'e-commerce Home Page- Live Mode', { testIsolation: true }, () => {
 	beforeEach( () => {
 		wpLogin();
-		// uninstallPlugins();
 		comingSoon( false );
 		cy.visit( '/wp-admin/admin.php?page=' + pluginId + '#/home' );
 	} );

diff --git a/tests/cypress/integration/Home/ecommerce-next-steps.cy.js b/tests/cypress/integration/Home/ecommerce-next-steps.cy.js
@@ -1,7 +1,6 @@
 import { GetPluginId } from '../wp-module-support/pluginID.cy';
 import {
 	wpLogin,
-	comingSoon,
 	viewCompletedTasks,
 	viewRemainingTasks,
 } from '../wp-module-support/utils.cy';
@@ -155,7 +154,9 @@ describe( 'e-commerce Home Page- Next Steps', () => {
 			.scrollIntoView()
 			.invoke( 'removeAttr', 'target' )
 			.click();
-			cy.url().contains(
+			cy.url()
+				.should(
+				'contain',
 				'https://my.yoast.com/signup?redirect_to=https://academy.yoast.com/courses/'
 			);
 		cy.go( 'back' );

diff --git a/tests/cypress/integration/Store/storePage.cy.js b/tests/cypress/integration/Store/storePage.cy.js
@@ -11,7 +11,7 @@ describe(
 	() => {
 		before( () => {
 			wpLogin();
-			// uninstallPlugins();
+			uninstallPlugins();
 			cy.visit( '/wp-admin/admin.php?page=' + pluginId + '#/store' );
 		} );