Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update migration tests #371

Merged
merged 2 commits into from
Nov 6, 2024
Merged

update migration tests #371

merged 2 commits into from
Nov 6, 2024

Conversation

circlecube
Copy link
Member

These tests are failing in the latest bluehost release branch. Testing these seem fine, and referring to the cypress cloud videos, the tests step through and into the help-center properly, but the close button is not found when a click is attempted. I think the help is just taking a minute to load in the test but the test doesn't account for that.

  • use more specific targets for the close button
  • add timeout to the get method, hopefully it will be enough time to render the button

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

add a small wait for the app to open the help-center
use more specific targets for the close button.
@circlecube circlecube self-assigned this Nov 5, 2024
@wpscholar wpscholar requested a review from aratidgr8 November 6, 2024 15:21
@circlecube circlecube merged commit de7afe1 into trunk Nov 6, 2024
4 checks passed
@circlecube circlecube deleted the update/migration-test branch November 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants