Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make modal full screen for mobile viewport #17

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

circlecube
Copy link
Member

Proposed changes

This makes the mobile styles 100vh and 100vw so that the new ctb products can display properly. Also, some minor tweaks to the close button for layout and clickability on mobile.

See CAP-8658

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpalani May 29, 2024 19:32
@circlecube circlecube self-assigned this May 29, 2024
@circlecube
Copy link
Member Author

Here's a before and after screenshot of these changes:
Before

After

(the desktop view doesn't change - though I did increase height from 550 to 560 after loading a handful of ctb views, this seemed to make most of them a little better and didn't break any)

@circlecube circlecube requested a review from earnjam May 29, 2024 19:41
@circlecube circlecube merged commit cdc2849 into main May 30, 2024
3 checks passed
@circlecube circlecube deleted the update/mobile-styles branch May 30, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants