Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue: Some GlobaCTBs are not rendering well withing the modal because they require larger width/height. Since the module can't know or calculate the content of the iframe, it will rely on the source to communicate that information.
More info about this issue: https://jira.newfold.com/browse/PRESS1-406
The source may send a
postMessage
withtype: frameWidth
, when the value is received, we'll set the iframe width to that value. Then, the parent can ask the source/iframe to calculate the height and send anotherpostMessage
with height value.We're also refactoring the tests to make them slightly more granular.
Demo
ctb_dynamic-size.mp4
Type of Change
Checklist
Further comments
Internal Ticket: https://jira.newfold.com/browse/PRESS1-406