Scope Opens Sans font-family to modal #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
"Open Sans"
declaration on the body selector is not targeting the modal.We currently use the System Font Stack on the Brand Plugin UI -- was it intentional to have an Open Sans declaration.
In this PR I removed the broad selector and moved it into the modal scope. However, it's not clear to me that is needed.
Please review and consider removing both declarations entirely.
If the
"Open Sans"
selector is needed, it needs a fallback to the system font stack specified in Core.This fixes this rendering issue on the brand plugin admin page where UI outside the brand plugin page is affected by the "Open Sans" selection.
example-1.mp4
example-2.mp4
Production
Development
Video
Checklist
Further comments