Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope Opens Sans font-family to modal #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0aveRyan
Copy link
Member

Proposed changes

The "Open Sans" declaration on the body selector is not targeting the modal.

We currently use the System Font Stack on the Brand Plugin UI -- was it intentional to have an Open Sans declaration.

In this PR I removed the broad selector and moved it into the modal scope. However, it's not clear to me that is needed.

Please review and consider removing both declarations entirely.

If the "Open Sans" selector is needed, it needs a fallback to the system font stack specified in Core.

This fixes this rendering issue on the brand plugin admin page where UI outside the brand plugin page is affected by the "Open Sans" selection.

example-1.mp4
example-2.mp4

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

officiallygod
officiallygod previously approved these changes Dec 23, 2024
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, thanks.

Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, fixed the lint.
Thank You @0aveRyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants