Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/fix p3 again #44

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Update/fix p3 again #44

merged 5 commits into from
Jun 19, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Retry of #43

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested review from earnjam and wpalani June 19, 2024 22:10
@circlecube circlecube self-assigned this Jun 19, 2024
@circlecube circlecube mentioned this pull request Jun 19, 2024
Closed
8 tasks
@circlecube circlecube merged commit be8804c into main Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpalani wpalani wpalani approved these changes

@earnjam earnjam Awaiting requested review from earnjam

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @wpalani