Merge pull request #74 from newfold-labs/enhance/enable-skip404-by-de…

…fault Enable Skip 404 by Default
newfold-labs · Jan 22, 2025 · c196798 · c196798
2 parents d73f26a + 1fcb0f1
commit c196798
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/includes/Performance.php b/includes/Performance.php
@@ -334,7 +334,7 @@ public function add_to_runtime( $sdk ) {
 			'jetpack_boost_minify_css'          => get_option( 'jetpack_boost_status_minify-css', array() ),
 			'jetpack_boost_minify_css_excludes' => implode( ',', get_option( 'jetpack_boost_ds_minify_css_excludes', array( 'admin-bar', 'dashicons', 'elementor-app' ) ) ),
 			'install_token'                     => PluginInstaller::rest_get_plugin_install_hash(),
-			'skip404'                           => (bool) get_option( 'newfold_skip_404_handling', false ),
+			'skip404'                           => getSkip404Option(),
 		);
 
 		return array_merge( $sdk, array( 'performance' => $values ) );

diff --git a/includes/RestApi/SettingsController.php b/includes/RestApi/SettingsController.php
@@ -1,6 +1,8 @@
 <?php
 namespace NewfoldLabs\WP\Module\Performance\RestApi;
 
+use NewfoldLabs\WP\Module\Performance\Performance;
+
 /**
  * Class Settings
  *
@@ -77,7 +79,7 @@ public function set_options( $request ) {
 
 			switch ( $field['id'] ) {
 				case 'skip404':
-					$result = update_option( 'newfold_skip_404_handling', $field['value'] );
+					$result = update_option( Performance::OPTION_SKIP_404, $field['value'] );
 					break;
 
 				default: