Add/feature module #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpscholar
reviewed
May 15, 2024
includes/PerformanceFeature.php
Outdated
Comment on lines
53
to
79
| add_action( | ||
| 'newfold_container_set', | ||
| function ( Container $container ) { | ||
| register_activation_hook( | ||
| $container->plugin()->file, | ||
| function () use ( $container ) { | ||
| Skip404::onActivation(); | ||
| File::onActivation(); | ||
| Browser::onActivation(); | ||
| // Add headers to .htaccess | ||
| $responseHeaderManager = new ResponseHeaderManager(); | ||
| $responseHeaderManager->addHeader( 'X-Newfold-Cache-Level', absint( getCacheLevel() ) ); | ||
| } | ||
| ); | ||
| register_deactivation_hook( | ||
| $container->plugin()->file, | ||
| function () use ( $container ) { | ||
| Skip404::onDeactivation(); | ||
| File::onDeactivation(); | ||
| Browser::onDeactivation(); | ||
| // Remove all headers from .htaccess | ||
| $responseHeaderManager = new ResponseHeaderManager(); | ||
| $responseHeaderManager->removeAllHeaders(); | ||
| } | ||
| ); | ||
| } | ||
| ); |
There was a problem hiding this comment.
As discussed, I don't think we'll want to conditionally run activation/deactivation hooks. I also don't think that these would run early enough if they are registered in an action hook callback.
There was a problem hiding this comment.
I've got these hooks integrated better and moved into the PerformanceFeatureHooks class.
also incorporate them to feature enable and disable hooks
it has been moved to a standalone module
wpscholar
requested changes
May 21, 2024
wpscholar
approved these changes
May 21, 2024
wpscholar
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Type of Change
Checklist
Further comments