Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update solutions app test #43

Merged
merged 1 commit into from
Nov 22, 2024
Merged

update solutions app test #43

merged 1 commit into from
Nov 22, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Updates a solution test that has been flaky in attempt to make it more reliable.

Now navigates to the entitlements page via nav click rather than directly to page and adds a timeout to the intercept alias wait command. Not sure but about a quarter of the time this fails in the matrix tests, even though they pass locally 100% and they pass in the module and most tests in plugin.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

navigate to the entitlements page via nav click rather than directly to page
@circlecube circlecube self-assigned this Nov 21, 2024
@circlecube circlecube merged commit 22dd9c2 into main Nov 22, 2024
2 checks passed
@circlecube circlecube deleted the update/app-solutions-test branch November 22, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants