Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/repo org #1

Merged
merged 18 commits into from
Dec 20, 2024
Merged

Update/repo org #1

merged 18 commits into from
Dec 20, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

This is in preparation of migrating the bluehost repo to newfold-labs.

  • Update the workflow and npm scripts to build the plugin using the bluehost-wordpress-plugin folder name rather than the repo name.
  • Change the update URL in the new repo bootstrap file.

See https://jira.newfold.com/browse/PRESS10-41 for the full plan.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Dec 9, 2024
* main:
  minor composer dependency updates
  update plugin version to 3.15.7
  also include npm i to update package lock file with new version
  alpha order command
  add cleanup, build and i18n to npm command too
  update plugin file in version bump script too
  update package.json version with a script
  NPM Dev(deps-dev): Bump cypress from 13.16.0 to 13.16.1
  NPM(deps): Bump @heroicons/react from 2.1.5 to 2.2.0
  NPM Dev(deps-dev): Bump tailwindcss from 3.4.15 to 3.4.16
  NPM(deps): Bump @wordpress/i18n from 5.12.0 to 5.13.0
  NPM(deps): Bump react-router-dom from 6.28.0 to 7.0.2

# Conflicts:
#	bluehost-wordpress-plugin.php
#	composer.lock
#	package-lock.json
#	package.json
@circlecube
Copy link
Member Author

Some tests are failing and I've found that it is because in the test env the plugin slug matches the repo (wp-plugin-bluehost) and is not the same as when using the build (bluehost-wordpress-plugin) in an actual env. Thus the plugin uninstall commands were uninstalling our plugin during tests and then all following tests failed (for good reason). The modules uninstalling plugins are coming soon and e-commerce and I have created PRs to update those commands to specifically uninstall the plugins that the test installed rather than every plugin with an exclude list.

Once those are merged I can tag releases and update the modules in this PR (and remove the skipped tests) and then all tests should pass.

* main:
  Update description to mention PR due date is a week before
  run npm audit fix
  npm run set-version-bump - Version updated 3.15.7 => 3.15.8
  update solutions module and solutions test exclusion
  Add IDs to settings sections
  NPM(deps): Bump @reduxjs/toolkit from 2.4.0 to 2.5.0
  Composer(deps): Bump newfold-labs/wp-module-patterns from 2.8.0 to 2.8.1
  NPM Dev(deps-dev): Bump @wordpress/eslint-plugin from 21.6.0 to 22.0.0
  NPM(deps): Bump @wordpress/dom-ready from 4.13.0 to 4.14.0
  NPM(deps): Bump react-use from 17.5.1 to 17.6.0
  Fix 'isJarvis' check that always returned true
  Composer(deps): Bump newfold-labs/wp-module-data from 2.6.7 to 2.6.8

# Conflicts:
#	bluehost-wordpress-plugin.php
#	composer.json
#	composer.lock
#	languages/wp-plugin-bluehost.pot
#	package-lock.json
#	package.json
@circlecube circlecube requested a review from wpscholar December 20, 2024 20:54
@circlecube circlecube merged commit 7cf6c8e into main Dec 20, 2024
20 checks passed
@circlecube circlecube deleted the update/repo-org branch December 20, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants