Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/features module #576

Merged
merged 11 commits into from
Jun 6, 2024
Merged

Add/features module #576

merged 11 commits into from
Jun 6, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Add features module to HostGator and some other minor cleanup I found along the way.

See bluehost/bluehost-wordpress-plugin#1067 for reference.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested review from bradp, wpscholar and wpalani June 6, 2024 18:58
@circlecube circlecube self-assigned this Jun 6, 2024
@circlecube circlecube changed the base branch from main to develop June 6, 2024 19:01
circlecube added 2 commits June 6, 2024 15:06
@circlecube
Merge branch 'develop' into add/features-module
e33359f 
* develop:
  ecommerce version bump
  GitHub Actions(deps): Bump actions/add-to-project from 0.6.1 to 1.0.1

# Conflicts:
#	composer.json
@circlecube
composer run i18n for updated i18n files with new strings
8e44f77
@cypress Cypress
Copy link

cypress bot commented Jun 6, 2024 •
edited
Loading

1 flaky test on run #3733 ↗︎

0 330 28 0 Flakiness 1

Details:

composer run i18n for updated i18n files with new strings
Project: HostGator Plugin Commit: 8e44f77503
Status: Passed Duration: 23:51 💡
Started: Jun 6, 2024 7:10 PM Ended: Jun 6, 2024 7:34 PM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #576 ↗︎

@cypress Cypress
Copy link

cypress bot commented Jun 6, 2024 •
edited
Loading

1 flaky test on run #3731 ↗︎

0 329 29 0 Flakiness 1

Details:

Merge 0f7f623 into 8655d86...
Project: HostGator Plugin Commit: 8412f7e3f9 ℹ️
Status: Passed Duration: 24:07 💡
Started: Jun 6, 2024 7:04 PM Ended: Jun 6, 2024 7:28 PM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #576 ↗︎

@circlecube circlecube merged commit 305a35b into develop Jun 6, 2024
3 checks passed
@circlecube circlecube deleted the add/features-module branch June 6, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

@bradp bradp Awaiting requested review from bradp

@wpalani wpalani Awaiting requested review from wpalani

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @wpscholar