Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text casing on link prefetch strings #907

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix text casing on link prefetch strings #907

merged 1 commit into from
Jan 30, 2025

Conversation

arunshenoy99
Copy link
Member

Proposed changes

This ensures consistency with the text used in our other plugins. This was found by the failing test in newfold-labs/wp-module-performance#87

P.S. We will soon move all these strings to the module as part of newfold-labs/wp-module-performance#66

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@cypress Cypress
Copy link

cypress bot commented Jan 27, 2025

HostGator Plugin    Run #5742

Run Properties:  status check passed Passed #5742  •  git commit 9676f0cf95: Fix text casing on link prefetch strings
Project HostGator Plugin
Branch Review fix/text-casing
Run status status check passed Passed #5742
Run duration 27m 28s
Commit git commit 9676f0cf95: Fix text casing on link prefetch strings
Committer arunshenoy99
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 28
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 313
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Jan 27, 2025

HostGator Plugin    Run #5743

Run Properties:  status check passed Passed #5743  •  git commit 09b75e116b ℹ️: Merge 9676f0cf95626e2a77643d50eb047b8a8cb2fee4 into ac1f4a4c10eaf4f0dc7a2ac8f6dc...
Project HostGator Plugin
Branch Review fix/text-casing
Run status status check passed Passed #5743
Run duration 28m 15s
Commit git commit 09b75e116b ℹ️: Merge 9676f0cf95626e2a77643d50eb047b8a8cb2fee4 into ac1f4a4c10eaf4f0dc7a2ac8f6dc...
Committer Arun Shenoy
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 28
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 313
View all changes introduced in this branch ↗︎

@circlecube circlecube added this to the February 5, 2025 Release milestone Jan 30, 2025
@circlecube circlecube merged commit d057d9b into develop Jan 30, 2025
5 checks passed
@circlecube circlecube deleted the fix/text-casing branch January 30, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
February 5, 2025 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @circlecube