Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HIC license application name #9448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jphechter
Copy link
Contributor

Description

We're unable to search for home improvement contractor license applications because the license type is listed incorrectly in our code. This work fixes the license application name.

Ticket

This pull request resolves #188832886.

Approach

When this was initially reported, I thought the issue was with our data connector to MLO. In investigating that I realized that the license application we normally use to test this had a slightly different license application type than what we have recorded in the code. I queried the MLO database for all profession names and license types to validate that our records were accurate.

I found 2 mislabeled license types (only 1 is presently integrated which is why I started this work) and 1 new license application type (which I've alerted the content team about).

Fixing this in the code was effectively a copy change.

Steps to Test

When this is deployed to the dev environment, we should be able to query for HIC license applications.

  • Complete onboarding as a home improvement contractor
  • select business structure
  • open HIC license application task
  • search for a HIC license application using data from the test licenses spreadsheet

Notes

See approach regarding MLO query. No additional notes.

Code author checklist

  • I have rebased this branch from the latest main branch
  • I have performed a self-review of my code
  • My code follows the style guide
  • I have created and/or updated relevant documentation on the engineering documentation website
  • I have not used any relative imports
  • I have pruned any instances of unused code
  • I have not added any markdown to labels, titles and button text in config
  • If I added/updated any values in userData (including profileData, formationData etc), then I added a new migration file
  • I have checked for and removed instances of unused config from CMS
  • If I added any new collections to the CMS config, then I updated the search tool and cmsCollections.ts (see CMS Additions in Engineering Reference/FAQ on the engineering documentation site)
  • I have updated relevant .env values in both .env-template and in Bitwarden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant