Update HIC license application name #9448
Open
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're unable to search for home improvement contractor license applications because the license type is listed incorrectly in our code. This work fixes the license application name.
Ticket
This pull request resolves #188832886.
Approach
When this was initially reported, I thought the issue was with our data connector to MLO. In investigating that I realized that the license application we normally use to test this had a slightly different license application type than what we have recorded in the code. I queried the MLO database for all profession names and license types to validate that our records were accurate.
I found 2 mislabeled license types (only 1 is presently integrated which is why I started this work) and 1 new license application type (which I've alerted the content team about).
Fixing this in the code was effectively a copy change.
Steps to Test
When this is deployed to the
dev
environment, we should be able to query for HIC license applications.Notes
See approach regarding MLO query. No additional notes.
Code author checklist
userData
(includingprofileData
,formationData
etc), then I added a new migration filecmsCollections.ts
(see CMS Additions in Engineering Reference/FAQ on the engineering documentation site).env
values in both.env-template
and in Bitwarden