[NR-347440] CFN template validate lambda integration logs #17
Conversation
| exit_with_error "Log event with $attribute_key: $attribute_value not found in New Relic. Error Received: $response" | ||
| } | ||
|
|
||
| validate_logs_not_present() { |
There was a problem hiding this comment.
validate_logs_in_new_relic() and validate_logs_not_present() have common code, can be refactored to one method with a flag.
There was a problem hiding this comment.
in one method you are trying exponential backoff while in other it's simple retry, should have uniformity.
There was a problem hiding this comment.
@hrai-nr here it's retrying to check that logs should NOT get sent to new relic. Hence extended retry is not required in my opinion.
There was a problem hiding this comment.
Agree with @hrai-nr about being consistent with retry strategy here.
|
| @@ -7,12 +7,51 @@ on: | |||
| - main | |||
|
|
|||
| jobs: | |||
| run-e2e-tests: | |||
| run-e2e-tests-cloudwatch: | |||
There was a problem hiding this comment.
Is it going to run in parallel?
There was a problem hiding this comment.
yes, all tests will run in parallel
| cd .. | ||
| ./lambda-s3-trigger.sh ${{ matrix.test-case }} | ||
|
|
||
| clean-up: |
There was a problem hiding this comment.
What are we doing in cleanup?
There was a problem hiding this comment.
cleaning out templates s3 bucket, template artifacts and templates will be removed
| NEW_RELIC_LICENSE_KEY: ${{ secrets.NEW_RELIC_LICENSE_KEY }} | ||
| run: | | ||
| cd e2e-tests/common-scripts | ||
| ./build-templates.sh |
There was a problem hiding this comment.
We are building multiple times.
There was a problem hiding this comment.
Yes but since all the tests run in parallel it's going to take the same time as first building and passing build artifacts to parallel running test jobs
There was a problem hiding this comment.
Let me know what you think
.github/workflows/run-e2e-tests.yaml
Outdated
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.22' | ||
|
|
||
| - name: Install AWS SAM CLI | ||
| run: | | ||
| pip install aws-sam-cli | ||
|
|
||
| - name: Configure AWS Credentials | ||
| uses: aws-actions/configure-aws-credentials@v3 | ||
| with: | ||
| role-to-assume: ${{ secrets.AWS_E2E_ROLE }} | ||
| aws-region: us-east-1 |
There was a problem hiding this comment.
is it possible to avoid repeating common steps?
There was a problem hiding this comment.
@maya-jha but these are required steps in both the test jobs. I cannot add them as a common step and re-use. If you want it specifically in any way let me know.
| exit_with_error "Log event with $attribute_key: $attribute_value not found in New Relic. Error Received: $response" | ||
| } | ||
|
|
||
| validate_logs_not_present() { |
There was a problem hiding this comment.
Agree with @hrai-nr about being consistent with retry strategy here.
As part of this pr:
Create events in lambda from s3 and cloudwatch
Validate that logs are getting populated in New Relic on event creation.
Create scripts to fetch and validate logs in New Relic.