Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests workflow configuration modification #19

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+14 −5
Open

E2E tests workflow configuration modification #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb5437f
e2e tests will run only on pull request approval
ahegdeNR Jan 29, 2025
66c8c5d
added slack notification when e2e job fails
ahegdeNR Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .github/workflows/run-e2e-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: E2E Test Workflow

on:
pull_request:
branches:
- develop
- main
pull_request_review:
types:
- submitted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dummy review request


jobs:
run-e2e-tests:
if: github.event.review.state == 'approved'
runs-on: ubuntu-latest
permissions:
id-token: write
Expand Down Expand Up @@ -57,4 +57,13 @@ jobs:
env:
S3_BUCKET: unified-lambda-e2e-test-templates
run:
aws s3 rm "s3://$S3_BUCKET" --recursive
aws s3 rm "s3://$S3_BUCKET" --recursive

- name: Send failure notification to Slack
if: always()
uses: ravsamhq/notify-slack-action@v1
with:
status: ${{ job.status }}
notify_when: 'failure'
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which slack channel its referring to ? you can respond in dm.

Loading