-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nri-bundle] Adding ebpf agent to nri bundle. #1520
base: master
Are you sure you want to change the base?
[nri-bundle] Adding ebpf agent to nri bundle. #1520
Conversation
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
703af52
to
3054826
Compare
… pbeckwith/add-ebpf
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will require a review outside of me but LGTM
charts/nri-bundle/Chart.lock
Outdated
@@ -26,6 +26,9 @@ dependencies: | |||
- name: newrelic-pixie | |||
repository: https://newrelic.github.io/helm-charts | |||
version: 2.1.6 | |||
- name: nr-ebpf-agent | |||
repository: https://newrelic.github.io/helm-charts | |||
version: 0.1.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update it to 0.1.12?
charts/nri-bundle/Chart.yaml
Outdated
@@ -65,6 +66,11 @@ dependencies: | |||
condition: newrelic-pixie.enabled | |||
version: 2.1.6 | |||
|
|||
- name: nr-ebpf-agent | |||
version: 0.1.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.1.12?
<!-- Thank you for contributing to New Relic's Helm charts. Before you submit this PR we'd like to make sure you are aware of our technical requirements: * https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements For a quick overview across what we will look at reviewing your PR, please read our review guidelines: * https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md Following our best practices right from the start will accelerate the review process and help get your PR merged quicker. When updates to your PR are requested, please add new commits and do not squash the history. This will make it easier to identify new changes. The PR will be squashed anyways when it is merged. Thanks. For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file. Please make sure you test your changes before you push them. Once pushed, a Github Action will run across your changes and do some initial checks and linting. These checks run very quickly. Please check the results. We would like these checks to pass before we even continue reviewing your changes. --> #### Is this a new chart No #### What this PR does / why we need it: Adds the changes from #1520 #### Which issue this PR fixes *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)* - fixes # #### Special notes for your reviewer: #### Checklist [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.] - [x] Chart Version bumped - [x] Variables are documented in the README.md - [x] Title of the PR starts with chart name (e.g. `[mychartname]`) --------- Signed-off-by: kpattaswamy <[email protected]>
Is this a new chart
No.
What this PR does / why we need it:
Allows users to install the eBPF agent chart through the Nri bundle chart.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
N/A
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)