Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values.yaml #1529

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update values.yaml #1529

wants to merge 2 commits into from

Conversation

truegilb
Copy link
Contributor

Specify default sampling latency to p1. Showing explicit default value to end users for clarity.

Is this a new chart

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

Specify default sampling latency to p1.
@truegilb truegilb requested a review from a team as a code owner November 15, 2024 16:08
Version bump
Copy link
Member

@kpattaswamy kpattaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the update! Will just need to have this reflect in the readme to indicate this default value now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants