[newrelic-logging] enable sendMetrics and fluent bit metrics config by default #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voorepreethi
previously approved these changes
Dec 12, 2024
rohit-bandlamudi-nr
force-pushed
the
add-labels-for-entity-synthesis
branch
from
a38dea4 to
709e548
Compare
voorepreethi
previously approved these changes
Dec 18, 2024
voorepreethi
previously approved these changes
Dec 18, 2024
voorepreethi
previously approved these changes
Jan 7, 2025
voorepreethi
reviewed
Jan 7, 2025
rohit-bandlamudi-nr
force-pushed
the
add-labels-for-entity-synthesis
branch
from
751987d to
d108d79
Compare
rohit-bandlamudi-nr
changed the title
rohit-bandlamudi-nr
force-pushed
the
add-labels-for-entity-synthesis
branch
from
d108d79 to
c0b69fa
Compare
maya-jha
requested changes
Feb 3, 2025
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v2 | |||
| description: A Helm chart to deploy New Relic Kubernetes Logging as a DaemonSet, supporting both Linux and Windows nodes and containers | |||
| name: newrelic-logging | |||
| version: 1.23.5 | |||
| version: 1.23.6-beta | |||
There was a problem hiding this comment.
Why are we using beta here?
| Returns fluentbit config to collect and forward its metrics to New Relic | ||
| */}} | ||
| {{- define "newrelic-logging.fluentBit.monitoring.config" -}} | ||
| [INPUT] |
There was a problem hiding this comment.
Why don't we just keep this in values.yaml for better visibility.
maya-jha
reviewed
Feb 3, 2025
| @@ -174,7 +175,7 @@ fluentBit: | |||
| licenseKey ${LICENSE_KEY} | |||
| endpoint ${ENDPOINT} | |||
| lowDataMode ${LOW_DATA_MODE} | |||
| sendMetrics ${SEND_OUTPUT_PLUGIN_METRICS} | |||
| sendMetrics true | |||
There was a problem hiding this comment.
Do we need to enable this for fluent bit? It seems to me that its specific for sending output plugin related metrics. : https://github.com/newrelic/newrelic-fluent-bit-output/pull/142/files @jsubirat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
This PR enabled metrics forwarding by default and removes the option to enable / disable this behaviour. The labels that are required for fluent bit entity synthesis are also added as part of the prometheus remote-write configuration.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])