Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NR-98179] Address deprecation message in android agent #202

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ywang-nr
Copy link
Contributor

Ticket: https://new-relic.atlassian.net/browse/NR-98179

What's changed:

  1. Upgrade complieSDK and targetSDK from 28 to 30, to prep for later AEI features
  2. Deprecation messages include:
  • packageInfo.versionCode
  • Build.Serial
  • NetworkInfo class is deprecated
  • tm.getDeviceId() - not going to upgrade this method due to a manifest permission requirement
  • async task - not going to upgrade this method due to instrumentation

ToDo:

  1. Unit tests
  2. Real device testing with smoke tests

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 19.29825% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 54.21%. Comparing base (4da0a24) to head (151d4b6).
Report is 8 commits behind head on develop.

❗ Current head 151d4b6 differs from pull request most recent head 6f1101e. Consider uploading reports for the commit 6f1101e to get more accurate results

Files Patch % Lines
.../com/newrelic/agent/android/util/Connectivity.java 10.25% 28 Missing and 7 partials ⚠️
.../com/newrelic/agent/android/util/Reachability.java 30.00% 3 Missing and 4 partials ⚠️
...a/com/newrelic/agent/android/AndroidAgentImpl.java 60.00% 1 Missing and 1 partial ⚠️
...om/newrelic/agent/android/util/PersistentUUID.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #202      +/-   ##
=============================================
- Coverage      54.31%   54.21%   -0.11%     
+ Complexity      2961     2960       -1     
=============================================
  Files            306      306              
  Lines          15434    15469      +35     
  Branches        1680     1696      +16     
=============================================
+ Hits            8383     8386       +3     
- Misses          6175     6196      +21     
- Partials         876      887      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant