Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a noop Agent implementation #1587

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Provide a noop Agent implementation #1587

wants to merge 1 commit into from

Conversation

sdaubin
Copy link
Contributor

@sdaubin sdaubin commented Nov 13, 2023

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Add an accessor for a no-op instance of the agent api. This allows us to re-use many of the no-op api instances instead of having to redefine them in the bridge.

It also makes it easier to pass an instance of the agent into tests that don't use the full bytecode injecting agent.

Moving forward, as we add more methods to Agent, we will have less code to write in the bridge.

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,

Checks

  • [X ] Your contributions are backwards compatible with relevant frameworks and APIs.
  • [X ] Your code does not contain any breaking changes. Otherwise please describe.
  • [X ] Your code does not introduce any new dependencies. Otherwise please describe.

@sdaubin
Copy link
Contributor Author

sdaubin commented Nov 17, 2023

Unfortunately this is broken because of the K2 agent :(

@sdaubin sdaubin marked this pull request as draft November 17, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants