-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add security scan with trivy #985
Open
lavarou
wants to merge
4
commits into
dev
Choose a base branch
from
ci/add-security-scan
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lavarou
force-pushed
the
ci/add-security-scan
branch
from
November 14, 2024 16:57
5f42176
to
8b9aa46
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #985 +/- ##
==========================================
- Coverage 78.54% 78.45% -0.09%
==========================================
Files 196 196
Lines 27103 27100 -3
==========================================
- Hits 21287 21262 -25
- Misses 5816 5838 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
lavarou
force-pushed
the
ci/add-security-scan
branch
3 times, most recently
from
November 15, 2024 01:17
4cb8d62
to
cab9c27
Compare
Security scan with trivy will be run on push to main and dev, pull request, and daily. trivy will skip scanning vendor subdirectory because the agent is not using code from that directory.
Storing trivy scan configuration in a file will ensure the same configuration is used regardless if trivy is run as GitHub action or when trivy is used locally.
Use mirror.gcr.io as source registry for trivy-db in attempt to avoid `TOOMANYREQUESTS` error when downloading it from default registry (ghcr.io).
Ignore AVD-DS-0026 (missing HEALTHCHECK in Dockerfile) reported in `files/Dockerfile`, which is used to build `devenv` service container image. `devenv` service container is used to run an interactive shell and having `HEALTHCHECK` in such a service doesn't make sense.
lavarou
force-pushed
the
ci/add-security-scan
branch
from
November 20, 2024 14:39
cab9c27
to
eccaf64
Compare
bduranleau-nr
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security scan with trivy will be run on push to main and dev, pull request, and daily. trivy will skip scanning vendor subdirectory because the agent is not using code from that directory.