Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kbauer/use semver tags #158

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Kbauer/use semver tags #158

merged 2 commits into from
Dec 2, 2024

Conversation

kb-newrelic
Copy link
Contributor

@kb-newrelic kb-newrelic commented Nov 26, 2024

Summary (JIRA ticket)

Moving to git tags following semantic conventions, i.e. without a distro prefix to get native support for goreleaser and similar release tools and avoid having to rely on bash scripts to bridge those gaps.

  • CI previously encoded the 'distributions to release' in the prefix. Given that there is currently only one distro, we can hardcode this as input where necessary. When adding a new distro, we will publish all artifacts on the same version and increment the version based on the most impactful change to any distro (instead of maintaining a version per prefixed-version per distro). This is also what the open-telemetry repo does.
  • Main changes are to .github/workflows/scripts/set_version.sh which no longer has to deal with the distro prefix (hardcoded wherever code relied upon the output of this script). Some modifications were necessary to still enforce version consistency across distros but most of the logic was borrowed from this script checking names in the manifest

Misc

  • Removed unused push-tags target (copy of releases repo) from build.mk to avoid confusion as it also relates to tagging.

Preparation

Before this will pass CI, we'll have to merge two dummy commits with tags adhering to semantic versioning, e.g. 0.8.6 and 0.8.7.

  • Without prep, the build was failing as expected with error indicating most recent tag not adhering to semver.
  • PR for 0.8.6
  • PR for 0.8.7
  • tagged both commits with annotated tags and pushed to github
git tag -a '0.8.6' -m 'release 0.8.6' afb1b521bbe2868336b0d384f82b4e35897f7af9
git tag -a '0.8.7' -m 'release 0.8.7' a6cc0f2a39a248e5855f9130b903517f975de8b4
git push origin 0.8.6
git push origin 0.8.7
  • rebased this PR, retriggering CI with two most recent tags being semver-compliant -> CI passes

@kb-newrelic kb-newrelic force-pushed the kbauer/use-semver-tags branch from 98b47dc to e737f8c Compare December 2, 2024 18:28
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very exciting.

@kb-newrelic kb-newrelic merged commit 1969a9c into main Dec 2, 2024
6 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/use-semver-tags branch December 2, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants